-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support 0-generator FreeMagma
and FreeSemigroup
?
#4424
Comments
I am neutral on this. But the work invested in making this possible should be proportional to how useful this is; if this is just there out of completeness, clearly it's far less pressing; OTOH if somebody could really simplify their code if they had this... But to me, it seems somewhat esoteric? I am also slightly wary whether such an empty collection might break other parts of the code which do not expect such things. Of course that code then could also be fixed; so what I am really wary about is that the amount of work needed to make this happen might spiral out of control. That said, I have no fundamental objections at all, so if someone wants to make this happen, you are most welcome :-). |
I think supporting empty domains is asking for trouble. (For example, sooner or later people will ask for maps and morphisms between them, etc., and already the question when two such maps are equal might be challenging in GAP.) The documentation of Perhaps the term "0-generator objects" mentioned in issue #1385 is misleading, empty lists of generators should be supported if the domains themselves are not empty; for example the trivial subgroup of a group usually has an empty list of generators, and tests for this situation are important; but this is a different issue. |
I've thought about this on-and-off recently, and I have settled on thinking that we should not support Therefore I will close this issue. Note that
|
This comes from @markuspf in #1385:
This may or may not be a good idea. Possibly we also want 0-generator
FreeMonoid
andFreeMagmaWithOne
(which would be trivial).The text was updated successfully, but these errors were encountered: