Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regressions caused by libgap.pc PR #5113

Closed
fingolfin opened this issue Oct 14, 2022 · 3 comments · Fixed by #5115
Closed

Regressions caused by libgap.pc PR #5113

fingolfin opened this issue Oct 14, 2022 · 3 comments · Fixed by #5115
Labels
regression A bug that only occurs in the branch, not in a release topic: ci Anything related to GitHub Actions, Codecov, AppVeyor, Coveralls, Travis, ...

Comments

@fingolfin
Copy link
Member

fingolfin commented Oct 14, 2022

Unfortunately PR #5080 by @dimpase (UPDATE: together with PR #5106 by me -- which also had a bug completely of its own) introduced a few regressions:

  1. weirdly, the makemanuals ... CI test is now failing
  2. every time one enters make now, even if nothing else is to be done, one now gets this message:
$ make
Package libgap was not found in the pkg-config search path.
Perhaps you should add the directory containing `libgap.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libgap' found

I am guessing problem 2 is because the (shell PKG_CONFIG_PATH=$(DESTDIR)$(libdir)/pkgconfig pkg-config --modversion libgap) is always executed. I think to fix this one needs to replace the ifeq by a shell if.

No idea right now what causes 1, but it might in fact be related

@fingolfin fingolfin added regression A bug that only occurs in the branch, not in a release topic: ci Anything related to GitHub Actions, Codecov, AppVeyor, Coveralls, Travis, ... labels Oct 14, 2022
@fingolfin
Copy link
Member Author

Aha, I think I see what went wrong with 1. I'll submit a PR to deal with both

@dimpase
Copy link
Member

dimpase commented Oct 14, 2022

mea cupla...

@fingolfin
Copy link
Member Author

Nah, no worries. Tests didn't catch it, and >60% of the problem were my fault anyway :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression A bug that only occurs in the branch, not in a release topic: ci Anything related to GitHub Actions, Codecov, AppVeyor, Coveralls, Travis, ...
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants