fix(k8s): include value files in default Helm include clause

garden-io · Feb 25, 2020 · 2427805 · 2427805
1 parent 5180604
commit 2427805
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/garden-service/src/plugins/kubernetes/helm/config.ts b/garden-service/src/plugins/kubernetes/helm/config.ts
@@ -289,9 +289,13 @@ export async function configureHelmModule({
     "release-name": getReleaseName(moduleConfig),
   }
 
+  const valueFiles = moduleConfig.spec.valueFiles
+
   // Automatically set the include if not explicitly set
   if (!(moduleConfig.include || moduleConfig.exclude)) {
-    moduleConfig.include = containsSources ? ["*", "charts/**/*", "templates/**/*"] : []
+    moduleConfig.include = containsSources
+      ? ["*", "charts/**/*", "templates/**/*", ...valueFiles]
+      : ["*.yaml", "*.yml", ...valueFiles]
   }
 
   return { moduleConfig }

diff --git a/garden-service/test/integ/src/plugins/kubernetes/helm/config.ts b/garden-service/test/integ/src/plugins/kubernetes/helm/config.ts
@@ -144,11 +144,11 @@ describe("configureHelmModule", () => {
     expect(configExclude.include).to.be.undefined
   })
 
-  it("should set include to empty if module does not have local chart sources", async () => {
+  it("should set include to default if module does not have local chart sources", async () => {
     // So that Chart.yaml isn't found
     patchModuleConfig("api", { spec: { chartPath: "invalid-path" } })
     const config = await garden.resolveModuleConfig(garden.log, "api")
-    expect(config.include).to.eql([])
+    expect(config.include).to.eql(["*.yaml", "*.yml"])
   })
 
   it("should not return a serviceConfig if skipDeploy=true", async () => {