fix: handle blank build args appropriately

garden-io · Jul 25, 2019 · 33c12eb · 33c12eb
1 parent 50c5720
commit 33c12eb
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/garden-service/src/plugins/container/build.ts b/garden-service/src/plugins/container/build.ts
@@ -70,7 +70,15 @@ export function getDockerBuildFlags(module: ContainerModule) {
   const args: string[] = []
 
   for (const [key, value] of Object.entries(module.spec.buildArgs)) {
-    args.push("--build-arg", `${key}=${value}`)
+
+    // 0 is falsy
+    if (value || value === 0) {
+      args.push("--build-arg", `${key}=${value}`)
+    } else {
+      // If the value of a build-arg is null, Docker pulls it from
+      // the environment: https://docs.docker.com/engine/reference/commandline/build/
+      args.push("--build-arg", `${key}`)
+    }
   }
 
   if (module.spec.build.targetImage) {