feat(k8s): add test and task support for kubernetes module type #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eysi09
requested changes
Jan 22, 2020
There was a problem hiding this comment.
Had a few minor comments.
Also wondering if we should add a guide similar to this one https://docs.garden.io/guides/using-helm-charts for the Kubernetes module type. Or merge the two into a single generic guide. These concepts are a little complicated IMO and the Helm charts guide does a really good job of explaining them.
We might also want to show this functionality in an example project. The current kubernetes-module example only uses remote container images. (It would also showcase how to reference the deployment image under the manifests field). We could in turn skip the redis service.
I'm fine with updating the guide in a follow-up PR but updating the example should be straightforward.
edvald
force-pushed
the
kubernetes-module-tests
branch
4 times, most recently
from
25c8d5b to
0b0f9b6
Compare
I basically re-used the same functionality from the `helm` module type. Nice and simple. Note: We may want to revisit that schema at some point, but I figured the sane approach would be to keep it consistent for now. Closes #1529
Added integ tests for the basic failing cases for Kubernetes module tests and tasks. Also added missing imports for the getTestResult and getTaskResult handlers to the kubernetes module type.
edvald
force-pushed
the
kubernetes-module-tests
branch
from
0ac1dab to
c5f20c4
Compare
edvald
force-pushed
the
kubernetes-module-tests
branch
from
c5f20c4 to
2f1ecc0
Compare
eysi09
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I basically re-used the same functionality from the
helmmodule type.Nice and simple.
Note: We may want to revisit that schema at some point, but I figured
the sane approach would be to keep it consistent for now.
Which issue(s) this PR fixes:
Closes #1529