feat: add ephemeral kubernetes provider #4927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumailxyz
force-pushed
the
feat-ephemeral-cluster
branch
from
b2ed9d6 to
d08c2d9
Compare
shumailxyz
force-pushed
the
feat-ephemeral-cluster
branch
from
149eb0e to
ea2c1f3
Compare
shumailxyz
changed the title
vvagaytsev
reviewed
Sep 12, 2023
10ko
previously requested changes
Sep 12, 2023
There was a problem hiding this comment.
Woop woop! I added a bunch of corrections and questions, mostly around the docs! Thanks for the PR @shumailxyz !!
|
@10ko Thanks for all the suggestions. I couldn't directly apply suggestions because I had some local changes to docs but manually used those. |
twelvemo
requested changes
Sep 13, 2023
|
Good to go for me, at least as a first version, we can iterate on it. I'll leave it to the others to approve, so all requests are taken into consideration. |
twelvemo
approved these changes
Sep 13, 2023
vvagaytsev
approved these changes
Sep 13, 2023
shumailxyz
dismissed stale reviews from 10ko and worldofgeese
dismissing due to being stale
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a new provider
ephemeral-kubernetesthat allows to use ephemeral clusters.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
examples/ephemeral-cluster-demoshowcasing use of ephemera-kubernetes provider. Will be adding the vote example using the new provider in separate PR.