Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(communityEdition): fix unprocessable entity error #5931

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

stefreak
Copy link
Member

What this PR does / why we need it:
Fix an issue where garden failed with the error "unprocessable entity" some times when user has more than 24 projects.

Previously core listed all projects and if it didn't find project with given name in the first list of results, it would attempt creating the project. Creating the project fails then with "unprocessable entity" because a project with the given name already exists.

Special notes for your reviewer:
Depends on a backend change, thus the draft state

@stefreak stefreak force-pushed the fix-unprocessable-entity branch from 320449f to 6845c44 Compare April 15, 2024 13:36
10ko
10ko previously approved these changes Apr 15, 2024
@stefreak stefreak marked this pull request as ready for review April 18, 2024 15:45
@stefreak stefreak force-pushed the fix-unprocessable-entity branch from 6845c44 to 56ce785 Compare April 18, 2024 15:45
@stefreak stefreak requested review from 10ko and twelvemo April 18, 2024 15:51
10ko
10ko previously approved these changes Apr 18, 2024
@stefreak stefreak force-pushed the fix-unprocessable-entity branch 2 times, most recently from eb943bb to 989d3f8 Compare April 18, 2024 16:01
@stefreak stefreak requested a review from 10ko April 18, 2024 16:02
@stefreak stefreak enabled auto-merge April 18, 2024 16:02
10ko
10ko previously approved these changes Apr 18, 2024
Fix an issue where garden failed with the error "unprocessable entity"
some times when user has more than 24 projects.

Previously core listed all projects and if it didn't find project with
given name in the first list of results, it would attempt creating the
project. Creating the project fails then with "unprocessable entity"
because a project with the given name already exists.
Copy link
Collaborator

@twelvemo twelvemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@stefreak stefreak added this pull request to the merge queue Apr 19, 2024
Merged via the queue into main with commit bfcc1fe Apr 19, 2024
40 checks passed
@stefreak stefreak deleted the fix-unprocessable-entity branch April 19, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants