improvement(cli): more detailed logging in cloud secret commands
#6065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverse refactoring.
twelvemo
approved these changes
May 22, 2024
vvagaytsev
added a commit
that referenced
this pull request
May 23, 2024
It was already addressed in #6065
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 24, 2024
* refactor: add api method for secret creation * refactor: add helper method for bulk secret creation * refactor: introduce request object for bulk secrets creation * refactor: introduce interface for secret object * refactor: re-use helper for bulk secret creation * refactor: rename some arguments * chore: use sets instead of arrays for faster lookup * fix: fix bug introduced in 9336aaa * test: fix test assertion * fix: fix another bug introduced in 9336aaa * chore: remove unnecessary log line Detailed messages are printed in the loop below. * refactor: rename type alias * refactor: avoid unnecessary data conversion * refactor: add api method for secret update * refactor: introduce request object for bulk secrets update * chore: update todo-comment * refactor: introduce named type * refactor: build secrets requests in a dedicated function * refactor: extract named interface * chore: remove outdated comment It was already addressed in #6065
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Improved logging and more refactoring in
garden cloud secrets ...commands.Predecessor for fixing #6048.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Based of #6064.
See individual commits for the details.