fix: resolve parts of template strings, even if another part cannot be resolved yet. #6751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes an issue where in certain cases we get errors like "
Could not find key item" or "Could not find key inputs" since0.13.46, where the template parser has been rewritten.Another PR is currently in progress, #6745, which will also fix this issue by capturing contexts instead of partially resolving templates. That PR won't get ready this week anymore though.
This fix is not complete, as the implementtion before 0.13.45 was not either – in certain situations partial resolution isn't cutting it, for example a template string like
${actions.build[input.name].outputs.log}. Those cases will be solved by #6745