fix: do not crash on missing deploymentRegistry for in-cluster builds
#6768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uster build mode Throw a configuration error instead.
|
Conditional validation done in 250b658 broke the docs generation. I need to take a closer look at that. |
It requires more changes in the docs generation process. Now we do npt use `joi.alternatives` with conditional validation anywhere in the project, and the docs generation does not support that option. That can be done later in a separate PR if necessary.
10ko
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A
ConfigurationErroris now thrown instead ofInternalErrorif thedeploymentRegistryis not configured on the provider-level when using in-cluster building.So Garden do not crash and quits gracefully with informative error message.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
An attempt to use conditional validation for
deploymentRegistryof the provider configuration was taken in 250b658.It was reverted because of the of conditional validation support in the reference docs generation.