fix(k8s): ensure image pull secret is always created for K8s Deploy #6795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue were in some (edge) cases the image pull secret is created in the target namespace is using the `kubernetes` Deploy type. I say edge case because the image pull secret is usually ensured in other code paths, e.g. when initialising in-cluster builders and as AFAICT this only happens if using the cloud builder in the k8s Deploy type. The operation is idempotent so calling it again here should be fine. TODO @Myself: I want to refactor this flow a little bit in a follow up commit but wanted to get the fix out the way first.
twelvemo
approved these changes
Jan 23, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This fixes an issue were in some (edge) cases the image pull secret is created in the target namespace is using the
kubernetesDeploy type.I say edge case because the image pull secret is usually ensured in other code paths, e.g. when initialising in-cluster builders and as AFAICT this only happens if using the cloud builder in the k8s Deploy type.
The operation is idempotent so calling it again here should be fine.
TODO @Myself: I want to refactor this flow a little bit in a follow up commit but wanted to get the fix out the way first.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: