Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: when using create project, the project name is undefined #6797

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix: when using create project, the project name is undefined #6797

merged 1 commit into from
Jan 23, 2025

Conversation

10ko
Copy link
Member

@10ko 10ko commented Jan 23, 2025 •
edited
Loading

What this PR does / why we need it:

Found this little bug which was causing the garden create project command to render a project.garden.yaml file with an undefined project name.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@10ko 10ko requested a review from vvagaytsev January 23, 2025 14:15
vvagaytsev
vvagaytsev approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@vvagaytsev vvagaytsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@vvagaytsev vvagaytsev enabled auto-merge January 23, 2025 14:21
@vvagaytsev vvagaytsev added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit 39a6345 Jan 23, 2025
40 checks passed
@vvagaytsev vvagaytsev deleted the fix-create-command-input-name branch January 23, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvagaytsev vvagaytsev vvagaytsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@10ko @vvagaytsev