fix(k8s): do not throw if paused resource is missing #6799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix, we'd check for paused Helm resources by listing all rendered resources and not handling the error if the resource isn't deployed in the first place. Furthermore, we were missing an `await` statement so the 404 error from a missing resource would pop up at a random time, usually after the status handler returns. So essentially a `helm` Deploy could fail if using AEC and a potentially paused resource was missing. Now we correctly ignore rendered resources that haven't been deployed and await for the API call.
vvagaytsev
approved these changes
Jan 24, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Before this fix, we'd check for paused Helm resources by listing all rendered resources and not handling the error if the resource isn't deployed in the first place.
Furthermore, we were missing an
awaitstatement so the 404 error from a missing resource would pop up at a random time, usually after the status handler returns.So essentially a
helmDeploy could fail if using AEC and a potentially paused resource was missing.Now we correctly ignore rendered resources that haven't been deployed and await for the API call.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: