improvement: add better error handling when failing to archive test artifacts #6802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtifacts Co-authored-by: Steffen Neubauer <steffen@garden.io>
vvagaytsev
changed the title
vvagaytsev
approved these changes
Jan 24, 2025
stefreak
reviewed
Jan 24, 2025
| // Anything above two minutes for this would be unusual | ||
| timeoutSec: 120, | ||
| // Anything above 10 minutes for this would be unusual | ||
| timeoutSec: 600, |
There was a problem hiding this comment.
In my opinion, 10 minutes is way too much, two minutes was already a lot for running tar --help.
Imagine how a user would feel seeing "timed out after 10 minutes running tar --help" as an error message
stefreak
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Improve error handling when trying to create the archive of artifacts.
Additionally, increases the timeout for the
tarcommand to 10 minutes.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: