feat: allow cross-referencing variables in the same scope #6814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid resolving variables before creating the variable context; Otherwise variables cannot reference parent scope and their peers.
We need to make sure variables have access to the entire surrounding context, but we also retain fine-grained control over precendence and cross-referencing.
…esolving built-in keys like dependencies early Add an `isFinalContext` flag to `VariablesContext`, encapsulating the behaviour we require where we have to allow access to variables despite a `$merge` operation on the same nesting level cannot be resolved. We only store resolved variables in `ResolveActionTask`, and rely on the nature of lazy evaluation to fail when we have to.
vvagaytsev
reviewed
Feb 3, 2025
Comment on lines
+17
to
+23
| /* | ||
| * Copyright (C) 2018-2024 Garden Technologies, Inc. <info@garden.io> | ||
| * | ||
| * This Source Code Form is subject to the terms of the Mozilla Public | ||
| * License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| * file, You can obtain one at http://mozilla.org/MPL/2.0/. | ||
| */ |
There was a problem hiding this comment.
Duplicate license header can be removed :)
vvagaytsev
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allows cross-referencing variables in the same scope.
Which issue(s) this PR fixes:
Fixes #2730 (and some regressions of variable lookup behaviour introduced in #6745, there is no need to mention them in the release notes because we have not released it so far)
Special notes for your reviewer:
There are some caveats that are covered in the test cases, to maintain backwards-compatibility with older versions of 0.13.