fix: validate secrets before action resolution #6822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validate missing secrets when instantiating a `ResolveActionTask` , rather than when adding configs. This would ensure we only get the error when missing secrets would actually cause a failure for the given command, while still failing relatively early even if the action happens to use another action’s outputs.
…r if action references missing secrets when user is not logged in
…erences missing secrets The missing secrets check was moved to `ResolveActionTask` constructor.
…erences missing secrets The missing secrets check was moved to `ResolveActionTask` constructor.
…rences missing secrets
…ferences missing secrets
…nfig" tests suite
stefreak
reviewed
Feb 5, 2025
* Not logged in * Has no secrets
The error message depends on the login status to be less confusing.
…r if module references missing secrets
Some secrets might be missing and not resolvable now, because the missing secrets check was moved to `ResolveActionTask` constructor.
stefreak
reviewed
Feb 6, 2025
stefreak
reviewed
Feb 6, 2025
stefreak
previously approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Validate missing secrets when instantiating a
ResolveActionTask, rather than when adding configs.This would ensure we only get the error when missing secrets would actually cause a failure for the given command, while still failing relatively early even if the action happens to use another action’s outputs.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: