-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement(terraform): enable streaming logs to cloud #6829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6017df0
to
cd16c89
Compare
cd16c89
to
b0c4491
Compare
This commit introduces a config option to optionally stream Terraform logs to Garden Cloud/Enterprise. Defaults to `false` but we may reconsider in a later breaking change release.
b0c4491
to
d452060
Compare
thsig
approved these changes
Feb 10, 2025
twelvemo
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could always stream them, if there are sensitive values they can be hidden with the sensitive
flag in terraform. But either way happy to see this!
vvagaytsev
added a commit
that referenced
this pull request
Feb 10, 2025
Follow-up docs update for #6829.
vvagaytsev
added a commit
that referenced
this pull request
Feb 10, 2025
Follow-up docs update for #6829.
vvagaytsev
added a commit
that referenced
this pull request
Feb 10, 2025
Follow-up docs update for #6829.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
* chore: disable too-early deprecation arning for builtin plugins * chore: re-work deprecation for old plugins * chore: deprecate hadolint plugin * chore: deprecate octant plugin * chore: deprecate contest plugin * docs: re-generate docs * docs: re-generate terraform docs Follow-up docs update for #6829.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This commit introduces a config option to optionally stream Terraform
logs to Garden Cloud/Enterprise.
Defaults to
false
but we may reconsider in a later breaking changerelease.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: