Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(terraform): enable streaming logs to cloud #6829

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

eysi09
Copy link
Collaborator

@eysi09 eysi09 commented Feb 9, 2025

What this PR does / why we need it:

This commit introduces a config option to optionally stream Terraform
logs to Garden Cloud/Enterprise.

Defaults to false but we may reconsider in a later breaking change
release.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@eysi09 eysi09 changed the title Tf stream logs improvement(terraform): enable streaming logs to cloud Feb 9, 2025
@eysi09 eysi09 marked this pull request as ready for review February 9, 2025 21:33
@eysi09 eysi09 requested review from thsig and twelvemo February 9, 2025 21:33
This commit introduces a config option to optionally stream Terraform
logs to Garden Cloud/Enterprise.

Defaults to `false` but we may reconsider in a later breaking change
release.
@thsig thsig added this pull request to the merge queue Feb 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 10, 2025
@eysi09 eysi09 added this pull request to the merge queue Feb 10, 2025
Copy link
Collaborator

@twelvemo twelvemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could always stream them, if there are sensitive values they can be hidden with the sensitive flag in terraform. But either way happy to see this!

Merged via the queue into main with commit 0fac9d0 Feb 10, 2025
42 checks passed
@eysi09 eysi09 deleted the tf-stream-logs branch February 10, 2025 09:52
vvagaytsev added a commit that referenced this pull request Feb 10, 2025
Follow-up docs update for #6829.
vvagaytsev added a commit that referenced this pull request Feb 10, 2025
Follow-up docs update for #6829.
vvagaytsev added a commit that referenced this pull request Feb 10, 2025
Follow-up docs update for #6829.
github-merge-queue bot pushed a commit that referenced this pull request Feb 10, 2025
* chore: disable too-early deprecation arning for builtin plugins

* chore: re-work deprecation for old plugins

* chore: deprecate hadolint plugin

* chore: deprecate octant plugin

* chore: deprecate contest plugin

* docs: re-generate docs

* docs: re-generate terraform docs

Follow-up docs update for #6829.
@stefreak stefreak mentioned this pull request Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants