fix(template): parse template strings in varfiles #6844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvagaytsev
force-pushed
the
fix/parse-vars-in-varfiles
branch
from
705e517 to
f96c3dd
Compare
vvagaytsev
force-pushed
the
fix/parse-vars-in-varfiles
branch
from
f96c3dd to
e35abb4
Compare
stefreak
reviewed
Feb 17, 2025
| configRoot: projectConfig.path, | ||
| path: environmentConfig.varfile, | ||
| defaultPath: defaultEnvVarfilePath(environment), | ||
| }) | ||
| const envVarfileVars = parseTemplateCollection({ | ||
| value: rawEnvVarfileVars, | ||
| source: { path: ["varfile"], yamlDoc: projectConfig.internal.yamlDoc }, |
There was a problem hiding this comment.
@thsig @vvagaytsev the source path and yamlDoc are incorrect; This will lead to confusing error messages when varfiles contain invalid template strings.
The minimum correct value here is source: { path: [] } if it's not yaml; to get correct source mapping for yaml varfiles we need to call parseTemplateCollection in loadVarfile, so we can pass the yaml document.
There was a problem hiding this comment.
Good catch! Thanks for fixing this in the follow-up PR.
This was referenced Feb 20, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A follow-up fix for #6745
Which issue(s) this PR fixes:
Fixes #6843
Special notes for your reviewer: