Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Garden does not throw validation errors for unknown keys in action configs #6846

Closed
vvagaytsev opened this issue Feb 12, 2025 · 0 comments · Fixed by #6875
Closed

[Bug]: Garden does not throw validation errors for unknown keys in action configs #6846

vvagaytsev opened this issue Feb 12, 2025 · 0 comments · Fixed by #6875
Assignees
@stefreak
Labels
bug priority:high High priority issue or feature regression A return to a previous and less advanced or worse state

Comments

@vvagaytsev
Copy link
Collaborator

vvagaytsev commented Feb 12, 2025 •
edited
Loading

Bug

Current behavior

Garden does not fail on invalid fields defined in the action-level configurations.

Expected behavior

Garden should fail with a validation error.

Reproducible example

Modify https://github.com/garden-io/garden/tree/main/examples/demo-project to define foo: bar in root-level config of any action.

Workaround

None.

Suggested solution(s)

Additional context

Introduced by #6745, likely by the changes in the validation flow in function resolveTemplates().

Your environment

garden version 0.13.53
@vvagaytsev vvagaytsev added bug regression A return to a previous and less advanced or worse state labels Feb 12, 2025
@vvagaytsev vvagaytsev changed the title [Bug]: Describe here [Bug]: Garden does not validate action configs Feb 12, 2025
@10ko 10ko added the priority:high High priority issue or feature label Feb 13, 2025
@edeustua edeustua mentioned this issue Feb 17, 2025
Closed
@thsig thsig changed the title [Bug]: Garden does not validate action configs [Bug]: Garden does not throw validation errors for unknown keys in action configs Feb 18, 2025
@stefreak stefreak assigned stefreak and unassigned thsig Feb 24, 2025
@stefreak stefreak mentioned this issue Feb 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefreak stefreak

Labels
bug priority:high High priority issue or feature regression A return to a previous and less advanced or worse state
Projects
None yet
Milestone
No milestone
4 participants
@stefreak @thsig @10ko @vvagaytsev