Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dependency error message rendering #6847

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

vvagaytsev
Copy link
Collaborator

@vvagaytsev vvagaytsev commented Feb 12, 2025

What this PR does / why we need it:

Fix the case when an action depends on runtime outputs of a disabled action.

Error rendering example before fix:

Run type=exec name=run-task depends on one or more runtime outputs from action
             key() {
        return actionReferenceToString(this);
    }, which is disabled. Please either remove the reference or enable the action.

Error rendering example after fix:

Run type=exec name=run-task depends on one or more runtime outputs from action deploy.tf-production, which is disabled. Please either remove the reference or enable the action.

The action.key function was not called in the error message, so it was rendered as a part of the code. Now it's fixed.
This PR also fixes some action name highlighting and removes unnecessary newline breaks from the error message.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Fix the case when an action depends on runtime outputs of a disabled action.
@vvagaytsev vvagaytsev added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit c7da2f2 Feb 12, 2025
40 checks passed
@vvagaytsev vvagaytsev deleted the fix/error-rendering branch February 12, 2025 17:40
@stefreak stefreak mentioned this pull request Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants