Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

[EPIC] santize user input in ExecCmd function #323

Closed
neo-liang-sap opened this issue Sep 22, 2020 · 2 comments
Closed

[EPIC] santize user input in ExecCmd function #323

neo-liang-sap opened this issue Sep 22, 2020 · 2 comments
Assignees

Comments

@neo-liang-sap
Copy link
Contributor

see discussion in #267 (comment)

I will use this issue to track all ExecCmd refactor work, and will list files i refactored here (to be appended as i'm continue working)

the ExecCmd function should not be called with a cmd string and instead the caller should pass the name and arguments directly for exec.Command, otherwise an attacker could sneak in arguments
@neo-liang-sap neo-liang-sap self-assigned this Sep 22, 2020
@neo-liang-sap
Copy link
Contributor Author

@neo-liang-sap neo-liang-sap changed the title santize user input in ExecCmd function [EPIC] santize user input in ExecCmd function Sep 22, 2020
@neo-liang-sap
Copy link
Contributor Author

close this issue as @tedteng has built many sub issue to track this
i will track my work and effort in different PR (each PR for one refactor)
/close

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants