Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort Cloud Profiles #207

Closed
grolu opened this issue Oct 12, 2018 · 5 comments · May be fixed by #1553
Closed

Sort Cloud Profiles #207

grolu opened this issue Oct 12, 2018 · 5 comments · May be fixed by #1553
Labels
area/cost Cost related area/usability Usability related component/dashboard Gardener Dashboard effort/2d Effort for issue is around 2 days kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) status/closed Issue is closed (either delivered or triaged)

Comments

@grolu
Copy link
Contributor

grolu commented Oct 12, 2018

The Garden Administrator needs an option to sort cloud profiles. This could be achieved by adding an annotation to all cloud profiles with an integer value. The annotation should be part of the garden cluster setup. This value could be used by the Gardener Dashboard (and other Tools / UIs) to sort infrastructures, as well as multiple Cloud Profiles within an infrastructure.

Imagine the following Cloud Profiles:

apiVersion: garden.sapcloud.io/v1beta1
kind: CloudProfile
metadata:
  name: aws
  annotations:
    garden.sapcloud.io/priority: 200
spec:
  aws:
...
apiVersion: garden.sapcloud.io/v1beta1
kind: CloudProfile
metadata:
  name: openstack-1
  annotations:
    garden.sapcloud.io/priority: 102
spec:
  openstack:
...
apiVersion: garden.sapcloud.io/v1beta1
kind: CloudProfile
metadata:
  name: openstack-2
  annotations:
    garden.sapcloud.io/priority: 101
spec:
  openstack:
...

Currently they would be ranked like this:

Infrastructures:

  • aws
  • openstack:
    • openstack-1
    • openstack-2

With the annotation, the dashboard would order the Cloud Profiles like this:

Infrastructures:

  • openstack:
    • openstack-2
    • openstack-1
  • aws

This feature helps to highlight / promote specific infrastructures or cloud profiles. It could also help reducing costs by ranking cheaper options first.

@grolu grolu added kind/enhancement Enhancement, improvement, extension component/dashboard Gardener Dashboard size/s Size of pull request is small (see gardener-robot robot/bots/size.py) area/cost Cost related area/usability Usability related labels Oct 12, 2018
@grolu grolu added the status/accepted Issue was accepted as something we need to work on label Oct 17, 2018
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Dec 17, 2018
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Feb 16, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Apr 18, 2019
@grolu
Copy link
Contributor Author

grolu commented May 22, 2019

And alternative way to solve this would be to allow to set preferred / default infrastructure and secret per project in the dashboard. This setting could be persisted as annotation on the project resource and would be shared with all members of a project.

@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jul 22, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Sep 21, 2019
@ghost ghost added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Nov 21, 2019
@ghost ghost added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jan 21, 2020
@ghost ghost added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Mar 22, 2020
@ghost ghost added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels May 21, 2020
@grolu
Copy link
Contributor Author

grolu commented Aug 7, 2020

@vlerenc @petersutter @holgerkoser I'm not sure about this. I don't think that someone actively requested this feature?

@vlerenc
Copy link
Member

vlerenc commented Aug 13, 2020

Hmm... @grolu wasn't there a planned application of that feature by @RaphaelVogel , but maybe we solved it differently? I can't recall anymore.

@gardener-robot gardener-robot added effort/2d Effort for issue is around 2 days and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Mar 8, 2021
@grolu
Copy link
Contributor Author

grolu commented Jun 2, 2022

Closed this as this does not seem to be a requirement.

@grolu grolu closed this as completed Jun 2, 2022
@gardener-robot gardener-robot added status/closed Issue is closed (either delivered or triaged) and removed status/accepted Issue was accepted as something we need to work on labels Jun 2, 2022
@grolu
Copy link
Contributor Author

grolu commented Mar 4, 2024

#1553
will solve this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cost Cost related area/usability Usability related component/dashboard Gardener Dashboard effort/2d Effort for issue is around 2 days kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants