Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Frontend Component Quality #975

Closed
grolu opened this issue Mar 16, 2021 · 0 comments · Fixed by #1838
Closed

Improve Frontend Component Quality #975

grolu opened this issue Mar 16, 2021 · 0 comments · Fixed by #1838
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related area/testing Testing related component/dashboard Gardener Dashboard kind/enhancement Enhancement, improvement, extension kind/roadmap Roadmap BLI lifecycle/stale Nobody worked on this for 6 months (will further age) size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Milestone
2024-Q1

Comments

@grolu
Copy link
Contributor

grolu commented Mar 16, 2021 •
edited
Loading

Currently, most of the frontend components do not fulfil our quality standards due to several reasons

  • Fuzzy interface (properties)
  • (deep) usage of storage dependencies
  • interaction through events and busses
  • ...

Components must not pass store data via properties to sub components and communicate via events.
We should map data directly to components where we need it and always work on a shoot staging resource in the store.
This is especially important for the components we use for shoot creation. The shoot resource must not be created with data stored in the components. The resource should always be up-to-date in the store.
@grolu grolu added kind/enhancement Enhancement, improvement, extension area/quality Output qualification (tests, checks, scans, automation in general, etc.) related component/dashboard Gardener Dashboard size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) area/testing Testing related labels Mar 16, 2021
@grolu grolu added this to the 2021-Q4 milestone Mar 17, 2021
@grolu grolu modified the milestones: 2021-Q4, 2022-Q3 Jul 12, 2021
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Jan 9, 2022
@grolu grolu modified the milestones: 2022-Q3, 2023-Q1 May 23, 2022
@grolu grolu modified the milestones: 2023-Q1, 2023-Q4 Nov 3, 2022
@grolu grolu modified the milestones: 2023-Q4, 2023-Q3 Mar 21, 2023
@grolu grolu modified the milestones: 2023-Q3, 2024-Q1 Sep 15, 2023
@grolu grolu mentioned this issue Feb 23, 2024
Open
4 tasks
@grolu grolu mentioned this issue May 6, 2024
Merged
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related area/testing Testing related component/dashboard Gardener Dashboard kind/enhancement Enhancement, improvement, extension kind/roadmap Roadmap BLI lifecycle/stale Nobody worked on this for 6 months (will further age) size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
2024-Q1
Development

Successfully merging a pull request may close this issue.

Migrate Inter-Component Communication to Centralized State Management gardener/dashboard
2 participants
@grolu @gardener-robot