Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Make etcd tuning flags to be configurable #507

Open
KesavanKing opened this issue Jan 11, 2023 · 1 comment
Open

[Feature] Make etcd tuning flags to be configurable #507

KesavanKing opened this issue Jan 11, 2023 · 1 comment
Assignees
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage)

Comments

@KesavanKing
Copy link

Feature (What you would like to be added):

As part of few performance tests on multi node etcd #107 we need the following flags to be configurable to arrive at the right tradeoff on initial bootstrap time of etcd nodes.

–heartbeat-interval
–election-timeout
–initial-election-tick-advance

Motivation (Why is this needed?):

Approach/Hint to the implement solution (optional):

@KesavanKing KesavanKing added the kind/enhancement Enhancement, improvement, extension label Jan 11, 2023
@abdasgupta abdasgupta self-assigned this Jan 11, 2023
@abdasgupta
Copy link
Contributor

Hi Kesavan, I created a branch https://github.com/abdasgupta/etcd-druid/tree/perf-test . I made some changes in https://github.com/abdasgupta/etcd-druid/blob/b87c104637a7719bf6ce9cdbf72ae47e49d18148/pkg/component/etcd/configmap/configmap.go#L161-L168 to include the flags you requested. Normally, we provide flag values through ETCD CR. But as you mentioned that these flags don't ensure that these will resolve race conditions that you facing during your perf tests, I added them only in configmap. You need to change the values of the flags in https://github.com/abdasgupta/etcd-druid/blob/b87c104637a7719bf6ce9cdbf72ae47e49d18148/pkg/component/etcd/configmap/configmap.go#L161-L168 and you have to execute three commands afterwards to push etcd-druid image to your personal docker repo. Then, you can use the same image for your tests.

The three commands after you make your changes here if necessary, are:
export IMG=<your-dockerhub-username>/etcd-druid:0.17.0-dev
make docker-build
make docker-push

Make sure that you are running docker desktop or docker daemon when you are executing the above commands. Make sure that you are running the above commands from the root directory of etcd-druid repo on your machine. Feel free to reach to me if needed any guidance.

@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Dec 4, 2023
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage)
Projects
None yet
Development

No branches or pull requests

3 participants