Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Make the metric metricsjobcurrent capture accurate job end time #685

Closed
abdasgupta opened this issue Sep 29, 2023 · 2 comments · Fixed by #711
Closed

[BUG] Make the metric metricsjobcurrent capture accurate job end time #685

abdasgupta opened this issue Sep 29, 2023 · 2 comments · Fixed by #711
Assignees
Labels
kind/bug Bug status/closed Issue is closed (either delivered or triaged)
Milestone

Comments

@abdasgupta
Copy link
Contributor

Describe the bug:
Currently the metric metricsjobcurrent is updated only when the delta event threshold crosses the limit and the compaction-controller in druid tries to create a new job or follow up the old job. But ideally, the metric should be updated even when the delta events are successfully compacted and the job is successful.

Expected behavior:
After a compaction job is run successfully and the delta events are compacted in backup, metric metricsjobcurrent should be updated to mark the end of the currently running job correctly in the dashboard. We can watch on the running compaction job status and as soon as the job is successful, we can update the metricsjobcurrent in the reconciler.

How To Reproduce (as minimally and precisely as possible):
Compaction job dashboard does not show the graph for metricsjobcurrent with correct end time of any successfully run compaction job.

Logs:

Screenshots (if applicable):

Environment (please complete the following information):

  • Etcd version/commit ID :
  • Etcd-druid version/commit ID :
  • Cloud Provider [All/AWS/GCS/ABS/Swift/OSS]:

Anything else we need to know?:

@shreyas-s-rao
Copy link
Contributor

Looks like this will be solved by #698 as a beneficial side-effect.

@shreyas-s-rao
Copy link
Contributor

/assign @abdasgupta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Bug status/closed Issue is closed (either delivered or triaged)
Projects
None yet
3 participants