Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

srcAndDstChecksEnabled MachineClass field is not set for K8s >= 1.22 clusters #444

Closed
ialidzhikov opened this issue Nov 8, 2021 · 2 comments · Fixed by #445
Closed

srcAndDstChecksEnabled MachineClass field is not set for K8s >= 1.22 clusters #444

ialidzhikov opened this issue Nov 8, 2021 · 2 comments · Fixed by #445
Assignees
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug platform/aws Amazon web services platform/infrastructure priority/3 Priority (lower number equals higher priority)

Comments

@ialidzhikov
Copy link
Member

How to categorize this issue?

/area quality
/kind bug
/priority 3
/platform aws

What happened:
@himanshu-kun found that #386 is actually incomplete. It sets only a value in the machineclass values but this value itself is not used in the machineclass template.

What you expected to happen:
The srcAndDstChecksEnabled field to be set to the appropriate value for K8s >= 1.22 clusters.

How to reproduce it (as minimally and precisely as possible):

  1. Create a K8s 1.22 cluster

  2. Make sure that the corresponding MachineClass does not have the srcAndDstChecksEnabled field set.

Environment:

  • Gardener version (if relevant):
  • Extension version: v1.30.0
  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • Others:
@ialidzhikov ialidzhikov added the kind/bug Bug label Nov 8, 2021
@gardener-robot gardener-robot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related platform/aws Amazon web services platform/infrastructure priority/3 Priority (lower number equals higher priority) labels Nov 8, 2021
@AxiomSamarth
Copy link
Collaborator

Thanks, @ialidzhikov. I will raise a PR with the correction.

@AxiomSamarth
Copy link
Collaborator

/assign @AxiomSamarth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug platform/aws Amazon web services platform/infrastructure priority/3 Priority (lower number equals higher priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants