Scale down of aws-custom-route-controller is not working when it is disabled #628
Labels
area/control-plane
Control plane related
kind/bug
Bug
platform/aws
Amazon web services platform/infrastructure
status/closed
Issue is closed (either delivered or triaged)
How to categorize this issue?
/area control-plane
/kind bug
/platform aws
What happened:
Shoots created with
provider-aws@v1.38.1
(hence affected by #619) have their aws-route-controller inCrashLoopBackOff
:The reason for it is that the controller is not managed by MR while its RBAC deployed in the Shoot is managed by MR. When aws-custom-route-controller gets disabled, its RBAC is deleted and the controller is not deleted -> it gets in
CrashLoopBackOff
because of the missing RBAC.#617 was attempt to mitigate this issue by scaling down the aws-custom-route-controller when it is disabled. But actually this PR does not mitigate/fix anything.
The corresponding
scaledDown
parameter inGetControlPlaneReplicas
is only evaluated when when the Shoot hibernation is enabled:gardener-extension-provider-aws/vendor/github.com/gardener/gardener/extensions/pkg/controller/shoot.go
Lines 105 to 110 in c9f432d
What you expected to happen:
aws-custom-route-controller to be deleted/scaled-down when it is disabled.
How to reproduce it (as minimally and precisely as possible):
Create a Shoot that enables
aws-custom-route-controller
.Disable the
aws-custom-route-controller
Make sure that after the disablement the
aws-custom-route-controller
is not deleted/scaled down.Anything else we need to know?:
Environment:
kubectl version
):The text was updated successfully, but these errors were encountered: