Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pods serving webhooks are missing readiness probes #382

Open
timebertt opened this issue Oct 11, 2021 · 2 comments
Open

Pods serving webhooks are missing readiness probes #382

timebertt opened this issue Oct 11, 2021 · 2 comments
Labels
area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) platform/azure Microsoft Azure platform/infrastructure

Comments

@timebertt
Copy link
Member

How to categorize this issue?

/area robustness
/kind enhancement
/platform azure

What would you like to be added:

Both the extension pods running in the seed and the validator pods running in the garden are missing readinessProbes.
We should add them to minimize webhook failures because of request being sent to unready pods.

@timebertt timebertt added the kind/enhancement Enhancement, improvement, extension label Oct 11, 2021
@gardener-robot gardener-robot added area/robustness Robustness, reliability, resilience related platform/azure Microsoft Azure platform/infrastructure labels Oct 11, 2021
@dkistner
Copy link
Member

I would recommend to vendor and use the default health manager from g/g here: https://github.com/gardener/gardener/blob/master/pkg/healthz/default.go

@timebertt
Copy link
Member Author

healthz.defaultHealthz doesn't implement the controller-runtime interface healthz.Checker.
I would go for the upstream healthz.Ping just like in gardener-admission-controller: https://github.com/gardener/gardener/blob/e77a0606aee264a703d2bc2727104c2db0d60951/cmd/gardener-admission-controller/app/gardener_admission_controller.go#L167-L169

@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Apr 11, 2022
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) platform/azure Microsoft Azure platform/infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants