Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make handing of floating pool (subnet) names more robust #129

Open
rfranzke opened this issue Aug 12, 2020 · 2 comments
Open

Make handing of floating pool (subnet) names more robust #129

rfranzke opened this issue Aug 12, 2020 · 2 comments
Labels
area/robustness Robustness, reliability, resilience related exp/intermediate Issue that requires some project experience kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) platform/openstack OpenStack platform/infrastructure priority/3 Priority (lower number equals higher priority) topology/garden Affects Garden clusters topology/seed Affects Seed clusters

Comments

@rfranzke
Copy link
Member

How to categorize this issue?

/area robustness
/kind enhancement
/priority normal
/platform openstack
/exp intermediate
/topology garden seed

What would you like to be added:
Today it's possible to provide these data in the InfrastructureConfig:

      floatingPoolName: FloatingIP-foo-bar
      floatingPoolSubnetName: 744165f5-06dc-4fac-a9d9-3590d1f76f09

There is no validation to prevent submitting a GUID while a name is expected. Consequently, the infrastructure reconciliation (or deletion) will fail.
To improve this I'm seeing two options at the moment:

  1. Improve validation code to forbid specifying a GUID when a name is expected
  2. Improve infrastructure reconciliation to be capable to also work with GUIDs, i.e., dynamically determine (based on the input) whether to work with the name or with the GUID.

Personally, I'd prefer the second option.

Why is this needed:
Robustness, better user experience, less ops effort.

@rfranzke rfranzke added the kind/enhancement Enhancement, improvement, extension label Aug 12, 2020
@gardener-robot gardener-robot added area/robustness Robustness, reliability, resilience related exp/intermediate Issue that requires some project experience platform/openstack OpenStack platform/infrastructure priority/normal topology/garden Affects Garden clusters topology/seed Affects Seed clusters labels Aug 12, 2020
@dkistner
Copy link
Member

Thanks for providing this. Makes sense from my point of view.
I think we can try the second option. Detecting a GUID should be easy. Maybe we should then also change the name of the to floatingPoolSubnet.

I guess this is not that urgent, right?

@rfranzke
Copy link
Member Author

👍 Yes, it's not. Changing the name is difficult as it wouldn't be backwards compatible, but we can introduce floatingPoolSubnet and deprecate floatingPoolSubnetName and remove it after some months.

@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Oct 28, 2020
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/normal labels Mar 8, 2021
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/robustness Robustness, reliability, resilience related exp/intermediate Issue that requires some project experience kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) platform/openstack OpenStack platform/infrastructure priority/3 Priority (lower number equals higher priority) topology/garden Affects Garden clusters topology/seed Affects Seed clusters
Projects
None yet
Development

No branches or pull requests

3 participants