Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable scale-down during cluster-rollouts. #472

Closed
hardikdr opened this issue Jun 10, 2020 · 1 comment · Fixed by #496
Closed

Disable scale-down during cluster-rollouts. #472

hardikdr opened this issue Jun 10, 2020 · 1 comment · Fixed by #496
Labels
kind/enhancement Enhancement, improvement, extension priority/2 Priority (lower number equals higher priority)

Comments

@hardikdr
Copy link
Member

What would you like to be added:

As discussed here https://github.com/gardener/autoscaler/issues/48#issuecomment-640600405 , we should add the annotation cluster-autoscaler.kubernetes.io/scale-down-disabled on the new machine-sets during roll-outs.

  • This will allow the system to keep CA running even during rolling-updates.
@hardikdr hardikdr added the kind/enhancement Enhancement, improvement, extension label Jun 10, 2020
@prashanth26
Copy link
Contributor

Points to remember during the implementation refer - https://github.com/gardener/autoscaler/issues/48#issuecomment-640600405

@danielfoehrKn danielfoehrKn mentioned this issue Jun 18, 2020
Merged
@hardikdr hardikdr mentioned this issue Aug 14, 2020
Merged
@prashanth26 prashanth26 added priority/blocker Needs to be resolved now, because it breaks the service priority/critical Needs to be resolved soon, because it impacts users negatively labels Aug 16, 2020
@gardener-robot gardener-robot removed the priority/blocker Needs to be resolved now, because it breaks the service label Aug 16, 2020
@gardener-robot gardener-robot added priority/2 Priority (lower number equals higher priority) and removed priority/critical Needs to be resolved soon, because it impacts users negatively labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Enhancement, improvement, extension priority/2 Priority (lower number equals higher priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Inhibit scale-down by autoscaler during roll-outs. hardikdr/machine-controller-manager
3 participants
@hardikdr @prashanth26 @gardener-robot