Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nil panic in MCM 0.51.0 relese, updateNodeToMachine #892

Closed
elankath opened this issue Jan 5, 2024 · 0 comments · Fixed by #893
Closed

Nil panic in MCM 0.51.0 relese, updateNodeToMachine #892

elankath opened this issue Jan 5, 2024 · 0 comments · Fixed by #893
Assignees
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug priority/1 Priority (lower number equals higher priority) status/closed Issue is closed (either delivered or triaged)

Comments

@elankath
Copy link
Contributor

elankath commented Jan 5, 2024

How to categorize this issue?

/area quality
/kind bug
/priority 1

What happened:

MC's updateNodeToMachine when unable to find the associated Machine obj for a given node erroneously attempts to print the nil machine objects name. This causes Integration Test failures.

	machine, err := c.getMachineFromNode(node.Name)
	if err != nil {
		klog.Errorf("Unable to handle update event for node %s, couldn't fetch machine %s, Error: %s", machine.Name, err)
		return
	}

What you expected to happen:

No nil access is made.

How to reproduce it (as minimally and precisely as possible):
Run the Integration Tests for any provider.

Anything else we need to know?:
NA

Environment:

NA

@elankath elankath added the kind/bug Bug label Jan 5, 2024
@gardener-robot gardener-robot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related priority/1 Priority (lower number equals higher priority) labels Jan 5, 2024
@elankath elankath self-assigned this Jan 5, 2024
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug priority/1 Priority (lower number equals higher priority) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants