checksums.json on puppetforge is incorrect

[elatt]

It seems that the value of metadata.json in the checksums.json file on the puppetforge is wrong which causes 'puppet module' command to complain that there are local edits when there are not.

[garethr]

Mmm, interesting. Could you post details of Puppet version and an output showing the problem?

I've just downloaded with puppet module and not been able to recreate the error.

[elatt]

Puppet version is irrelevant. If I simply fetch the latest tarball from the forge:
$ wget https://forgeapi.puppetlabs.com/v3/files/garethr-diamond-1.0.0.tar.gz

And then extract it and examine checksums.json:
"metadata.json": "6915ffd1a43d9815726ed6a44e5c5d6f",

But if I compute the md5 of that file it is actually "79a9a3cf7f601e23a7625259e5c73201"

Maybe in your testing, you simply downloaded the package from the forge but didn't try to upgrade it (it seems that puppet only checks the checksums on upgrade... it might be a good idea for them to validate on install as well to detect these broken packages but that's an upstream issue).