Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag Docker image for each BackstopJS release #562

Closed
fusionfox opened this issue Oct 11, 2017 · 7 comments
Closed

Tag Docker image for each BackstopJS release #562

fusionfox opened this issue Oct 11, 2017 · 7 comments

Comments

@fusionfox
Copy link

It would be great if we could lock down our dependancy to a particular release of BackstopJS using the docker container, but the only tag on there at the moment is 'latest'

https://hub.docker.com/r/backstopjs/backstopjs/

@TimPerry
Copy link

+1

1 similar comment
@rupamsaha
Copy link

+1

@garris
Copy link
Owner

garris commented Oct 11, 2017

What do you recommend? Let’s do it. Also, that container is new, I don’t remember what version of chrome it’s using — but we should set it to >=v62 to be compatible with the flags we’re using.

@garris
Copy link
Owner

garris commented Oct 11, 2017

FWIW: I don’t have much experience with containers— Would be super helpful if someone wants to take the lead to manage this.

@fusionfox
Copy link
Author

fusionfox commented Oct 12, 2017

I think the Docker container should have the same semver as the version of BackstopJS it's using, then we can lock down that dependancy.

Do you ever rebuild the container for the same version of Backstop?

@garris
Copy link
Owner

garris commented Oct 12, 2017

Sounds like a sensible idea.

I'm sorry but I am not sure I understand the question -- but I'll try to explain. The container rebuild is triggered on every github push -- regardless of package version. I only bump the package version value before releasing a new NPM build. Hope that helps.

@garris
Copy link
Owner

garris commented Feb 27, 2018

Closed by #668

@garris garris closed this as completed Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants