[puppeteer engine] npm run smoke_test failures

[garris]

About half of the tests are failing out.

We can release once we can get this test stable.

[krisdigital]

@garris I think I fixed them? #713

[garris]

Ok. Just tested this. Almost there!

There are a few subtle cases which need handling.

1. selectors which exist but are hidden
2. selectors which don't exist

These are handled the same in phantom and chromy options. Here is an example of the chromy handling...

This copies stub icons representing those states so that changes in selector visual states can be detected. E.G. reports look like this...

and...

It would be great to add a third handler which would display an icon for any other error. Currently our reports show nothing if some other unexpected error is thrown while attempting a capture.

[krisdigital]

@garris Aahhhh, now I remember seeing these images! Should be a small fix!

[garris]

Yeah. I think the fix is pretty easy too. Feel free to ping if you run into any difficulties — Cheers!

[garris]

Just FYI -- I updated the errorState graphics here... #716

Should not affect the fix here -- just changing the way it will look.

[krisdigital]

@garris It should work now! The new images are way cooler 😎 #718

[garris]

Great Job! Puppeteer branch is merged to master.
72d0b05

[krisdigital]

Wohoooooo!!