Cannot find module 'portfinder'

[kyleoliveiro]

I'm running Backstop locally via Docker. Everything was fine and dandy, until I ran docker pull backstopjs/backstopjs today. After downloading the latest image, running the same backstop command which was previously working now throws: Error: Cannot find module portfinder.

The Backstop version in the Docker image is apparently v3.5.4, yes, even though the latest on Docker hub right now is v3.5.3.

[ExelleR]

I have the same exact issue.

[zapatoche]

Hi there,
I have the same issue.

It's working again after installing portfinder globally.

[ExelleR]

Installing portfinder did not work for me only rolling back to the v3.2.17 of backstopjs container solved the issue.

[garris]

That sounds terrible. Sorry everyone. Will look into it.

[garris]

UPDATE: I could not reproduce the issue. However, there were a few commits not yet published to NPM. These did include some tweaks to the docker implementation for when you are using backstop inside a node script. I don't think this was causing your issue -- but I pushed this to NPM anyway.

So please try pulling down the lastest backstop locally and also from docker and please let me know if the problem is still there. And please provide logs and scenarios if your install is still broken. I really want to make sure the docker version is stable for everyone.

Alright. Thanks.

☮️

[zapatoche]

I have the issue with the local backstop version by the way, not the docker one. I will try again in a when I'm back at work, but my issue was fixed when I installed port finder manually.

[kyleoliveiro]

Hi @garris, I've pulled the latest Docker image, but unfortunately still having the same issue. Here's the log:

[ExelleR]

@kyleoliveiro @garris I have the same issue.

[garris]

Does this happen for puppeteer? Or just Chromy? I suspect this problem can be solved by adding portfinder to package.json as a hard dependency. This dependency was probably included in one of the react packages that was recently moved to dev-dependency.

Here 👉 #813

[thijsvdanker]

Installing portfinder globally fixed the issue for me.

npm install portfinder -g

(Running locally with chromy).

[kyleoliveiro]

I don't think installing portfinder globally would help in cases where Backstop is being run from the Docker container; It would need to be installed inside the container instead of the host machine for it to work.

@garris Puppeteer doesn't work for me, so I'm forced to use Chromy.

For now, I'm getting around this issue by using v3.2.17

[garris]

fixed by a82cff2

[seleckis]

Hi, I have fresh install of backstopJS 3.5.8. Worked well until I changed engine to "chromy". Now I have the same error.

[garris]

Ok, apologies. My bad. Please validate using v3.5.9. Thanks!

[cactusa]

I have just tested this and had no luck. Here is what I get:

BackstopJS v3.5.9
Loading config:  /Users/vladaltanov/Projects/itvplayer-browser/backstopJS.config.js 

COMMAND | Executing core for "test"
createBitmaps | Selected 45 of 45 scenarios.
module.js:491
    throw err;
    ^

Error: Cannot find module 'portfinder'
    at Function.Module._resolveFilename (module.js:489:15)
    at Function.Module._load (module.js:439:25)
    at Module.require (module.js:517:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/Users/vladaltanov/Projects/itvplayer-browser/node_modules/backstopjs/core/util/getFreePorts.js:1:82)
    at Module._compile (module.js:573:30)
    at Object.Module._extensions..js (module.js:584:10)
    at Module.load (module.js:507:32)
    at tryModuleLoad (module.js:470:12)
    at Function.Module._load (module.js:462:3)

This is not even using docker.

[garris]

Epic fail. 🤦‍♂️

Ok -- just republished. Please try again! v3.5.10

[cactusa]

Will try that first thing tomorrow when I'm back at the office.

[kyleoliveiro]

Just tried v3.5.10. It works, thanks!