Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old reference images are not cleaned up #65

Open
nag5000 opened this issue Jan 20, 2022 · 0 comments
Open

Old reference images are not cleaned up #65

nag5000 opened this issue Jan 20, 2022 · 0 comments

Comments

@nag5000
Copy link

nag5000 commented Jan 20, 2022

If I remove await backstop(assert); from a test or remove/rename a test with await backstop(assert);,
ember test && ember backstop-approve does not remove according (obsolete) image reference from bitmaps_reference/.
This is not a big problem, but since bitmaps_reference/ is committed to git, it would be great to autoremove old image references via ember backstop-approve.

For example:
1.

test('shows specific rental details', async function(assert) {
 await visit('/rentals');
 await click('.grand-old-mansion');
 await backstop(assert);
});
bitmaps_reference/ember-backstoptest_Acceptance__list_rentals__shows_specific_rental_details__assert0_0_document_0_webview.png
- test('shows specific rental details', async function(assert) {
+ test('foobar', async function(assert) {
$ ember test
$ ember backstop-approve

--->

actual:

bitmaps_reference/ember-backstoptest_Acceptance__list_rentals__shows_specific_rental_details__assert0_0_document_0_webview.png
+ bitmaps_reference/ember-backstoptest_Acceptance__list_rentals__foobar__assert0_0_document_0_webview.png

expected:

- bitmaps_reference/ember-backstoptest_Acceptance__list_rentals__shows_specific_rental_details__assert0_0_document_0_webview.png
+ bitmaps_reference/ember-backstoptest_Acceptance__list_rentals__foobar__assert0_0_document_0_webview.png
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant