Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS color-scheme property as a method option #194

Open
helenclx opened this issue Nov 15, 2024 · 3 comments
Open

Add CSS color-scheme property as a method option #194

helenclx opened this issue Nov 15, 2024 · 3 comments

Comments

@helenclx
Copy link
Contributor

Hi, I have a suggestion: Add the CSS color-scheme property as an option for the "method" field in the submission pull request template.

Like the prefers-color-scheme media query, color-scheme can be used to set light and dark theme by detecting user preferences. However, a major advantage color-scheme has over the prefers-color-scheme media query is being able to use the light-dark() function to set the colours on both light and dark mode.

I have switched to using the combination of color-scheme and light-dark() to set light and dark themes for my websites.

@garritfra
Copy link
Owner

Hi, thanks for the suggestion. I agree that this should be listed in the PR template. Do you have the capacity to open a PR for this?

@garritfra
Copy link
Owner

garritfra commented Nov 19, 2024

tangentially related: #195

@helenclx
Copy link
Contributor Author

Hi, thanks for the suggestion. I agree that this should be listed in the PR template. Do you have the capacity to open a PR for this?

Here it is: #196

Thank you for your reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants