fix(ViewportProvider): don't trigger duplicate updates for not idled events

garthenweb · garthenweb · commit d06e889cf9e6 · 2019-06-23T00:00:12.000+02:00
diff --git a/lib/ViewportProvider.tsx b/lib/ViewportProvider.tsx
@@ -104,7 +104,7 @@ export default class ViewportProvider extends React.PureComponent<
     const { isIdle } = Object.assign({ isIdle: false }, options);
     let updatableListeners = this.listeners.filter(
       ({ notifyScroll, notifyDimensions, notifyOnlyWhenIdle }) => {
-        if (notifyOnlyWhenIdle() && !isIdle) {
+        if (notifyOnlyWhenIdle() !== isIdle) {
           return false;
         }
         const updateForScroll = notifyScroll() && scrollDidUpdate;

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ export default class ViewportProvider extends React.PureComponent<`
`104`	`104`	`const { isIdle } = Object.assign({ isIdle: false }, options);`
`105`	`105`	`let updatableListeners = this.listeners.filter(`
`106`	`106`	`({ notifyScroll, notifyDimensions, notifyOnlyWhenIdle }) => {`
`107`		`- if (notifyOnlyWhenIdle() && !isIdle) {`
	`107`	`+ if (notifyOnlyWhenIdle() !== isIdle) {`
`108`	`108`	`return false;`
`109`	`109`	`}`
`110`	`110`	`const updateForScroll = notifyScroll() && scrollDidUpdate;`