Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-plugin-google-analytics): add TS typings for OutboundLink component #10215

Merged
merged 5 commits into from
Jan 28, 2019
Merged

feat(gatsby-plugin-google-analytics): add TS typings for OutboundLink component #10215

merged 5 commits into from
Jan 28, 2019

Conversation

thetrevorharmon
Copy link
Contributor

This PR adds typings to gatsby-plugin-google-analytics.

@thetrevorharmon thetrevorharmon self-assigned this Jan 8, 2019
@pieh pieh changed the title Added typings for Google Analytics Plugin feat(gatsby-plugin-google-analytics): add TS typings for OutboundLink component Jan 28, 2019
pieh
pieh approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated locally and works nicely. Thanks for adding those and sorry it took that long to get this PR processed. Now just waiting for CI to finish

@pieh pieh merged commit 7fee096 into gatsbyjs:master Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees

@thetrevorharmon thetrevorharmon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thetrevorharmon @pieh