Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-sitemap): add missing dependency pify and minimatch #10605

Merged
merged 2 commits into from
Dec 27, 2018
Merged

fix(gatsby-plugin-sitemap): add missing dependency pify and minimatch #10605

merged 2 commits into from
Dec 27, 2018

Conversation

MartinHelmut
Copy link
Contributor

@MartinHelmut MartinHelmut commented Dec 21, 2018

Description

The npm module pify is required inside the gatsby-plugin-sitemap but not added as a dependency. It is implicitly required by the installation of the dependencies of gatsby-plugin-feed, therefore nothing fails until a strict module handling is used, e.g. by pnpm.

Therefore I added it to the package.json of gatsby-plugin-sitemap to fix this.

@pieh
Copy link
Contributor

pieh commented Dec 21, 2018

Looks good - could you add minimatch as well?

@MartinHelmut
Copy link
Contributor Author

Ohh minimatch is missing as well? Okay, I will check that and add another commit 🙂

@MartinHelmut MartinHelmut changed the title fix(gatsby-plugin-sitemap): add missing dependency pify fix(gatsby-plugin-sitemap): add missing dependency pify and minimatch Dec 23, 2018
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @MartinHelmut!

@pieh pieh merged commit 726d5ab into gatsbyjs:master Dec 27, 2018
@gatsbot
Copy link

gatsbot bot commented Dec 27, 2018

Holy buckets, @MartinHelmut — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
…gatsbyjs#10605)

## Description

The npm module `pify` is required inside the `gatsby-plugin-sitemap` but not added as a dependency. It is implicitly required by the installation of the dependencies of `gatsby-plugin-feed`, therefore nothing fails until a strict module handling is used, e.g. by pnpm.

Therefore I added it to the `package.json` of `gatsby-plugin-sitemap` to fix this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants