fix: support cjs modules when loading typography config #10610
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After PR #10545 typography is loaded using
require(...).default
:gatsby/packages/gatsby-plugin-typography/src/gatsby-browser.js
Lines 12 to 13 in 93bf83b
It works with custom configs (which are ES6 modules), but it doesn't work with CommonJS modules.
Default config uses CommonJS export:
gatsby/packages/gatsby-plugin-typography/src/gatsby-node.js
Lines 19 to 23 in 93bf83b
This is why
typography
is not properly loaded and page crashes on load when using default config.Related Issues
Fixes #10609