fix(gatsby-transformer-remark): correctly pass cache to sub plugins #10892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSchau
commented
Jan 8, 2019
| @@ -58,6 +58,26 @@ const tableOfContentsCacheKey = node => | |||
| const withPathPrefix = (url, pathPrefix) => | |||
| (pathPrefix + url).replace(/\/\//, `/`) | |||
|
|
|||
| // TODO: remove this check with next major release | |||
| // the getCache feature was implemented in gatsby@2.0.88 | |||
| const safeGetCache = ({ getCache, cache, reporter }) => { | |||
There was a problem hiding this comment.
@pieh this warning looks like:
success onPreBootstrap — 0.004 s
success source and transform nodes — 0.072 s
success building schema — 0.175 s
success createPages — 0.030 s
success createPagesStatefully — 0.021 s
success onPreExtractQueries — 0.003 s
success update schema — 0.102 s
success extract queries from components — 0.119 s
warning It looks like you're using a slightly outdated version of gatsby with gatsby-transformer-remark.
To update, run 'npm install gatsby@^2.0.86 --save' or 'yarn add gatsby@^2.0.86'I thought about using onPreBootstrap but I like how we can remove this code all in one spot (easier refactoring). Up for whatever though.
There was a problem hiding this comment.
Also it'd be cool to think more broadly about how we introduce non-backwards compatible API changes, and if we could improve this.
For now this will work fine.
DSchau
commented
Jan 8, 2019
| @@ -4,7 +4,7 @@ | |||
| "version": "1.0.0", | |||
| "author": "Dustin Schau <dustin@gatsbyjs.com>", | |||
| "dependencies": { | |||
| "gatsby": "^2.0.71", | |||
| "gatsby": "^2.0.88", | |||
There was a problem hiding this comment.
These don't really matter. Just for local stuff!
DSchau
commented
Jan 8, 2019
| @@ -5,7 +5,7 @@ module.exports = function remarkPlugin({ cache, markdownAST }) { | |||
| visit(markdownAST, `html`, async node => { | |||
| if (node.value.match(id)) { | |||
| const value = await cache.get(id) | |||
| node.value = node.value.replace(/%SUBCACHE_VALUE%/, () => `>${value}<`) | |||
| node.value = node.value.replace(/%SUBCACHE_VALUE%/, value) | |||
DSchau
commented
Jan 8, 2019
| return cache | ||
| } | ||
| return getCache(id) | ||
| const safeGetCache = ({ getCache, cache }) => id => { |
There was a problem hiding this comment.
Note for posterity, we already warn on conflicting peerDeps, so a second warning would be sorta redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separate some changes from #10146, specifically so we can make this a non-breaking change if the right version of Gatsby isn't specified.
Notes:
Related Issues
Related to #10146