fix(google-analytics): fix pageview timing issue by delaying it

[jorgenblindheim]

There is still a problem with title and path not being correct while navigating across a page.

As referenced in: #9139
Solution made in: #2478 and #3362

For some reason the previous solution is being overwritten

[pieh]

For some reason the previous solution is being overwritten

It might be that context on why setTimeout was used was missing - can you add comment there to note why this is needed?

[drake-smith]

@jorgenblindheim @pieh Checking in here. I am experiencing the same issue (the page title fired off to GA is the previous page's title because GA updates before React-Helmet can update the meta info). I've simply installed gatsby-plugin-google-analytics and added my Tracking ID to gatsby-config- no extra or custom configuration.

Will this PR be merged in? This is a pretty fundamental bug that i think should be addressed as it essentially sending inaccurate info to Analytics. What is an alternate solution to making this fix myself? I do not have any experience in forking an npm package and making my own updates to it.

[wardpeet]

@drake-smith i'll be checking this out.

[wardpeet]

I switched setTimeout to requestAnimationFrames to make it a bit more robust as react-helmet is using requestAnimationFrames as well

[gatsbot]

Holy buckets, @jorgenblindheim — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!