Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-source-filesystem): report when downloading fails #10980

Merged
merged 3 commits into from
Jan 31, 2019

Conversation

oorestisime
Copy link
Contributor

@oorestisime oorestisime commented Jan 10, 2019

Description

While working on #10979 i came across this.
The queue was receiving the error as the result argument.
i Added a warn there in order to avoid failing silently

@oorestisime oorestisime requested a review from pieh January 27, 2019 20:26
@pieh pieh changed the title Fix queue errors and report when downloading fails fix(gatsby-source-filesystem): report when downloading fails Jan 29, 2019
@pieh
Copy link
Contributor

pieh commented Jan 31, 2019

Looking good. In the future we will want to move to use reporter.warn, but this is in general problematic right now because we don't pass reporter to createRemoteFileNode so for now console.warn is fine-ish

@oorestisime
Copy link
Contributor Author

should i open an issue for that?

@pieh
Copy link
Contributor

pieh commented Jan 31, 2019

@oorestisime We don't have issue for not using console.(log|warn|error) yet, so let's not create issue specifically for it yet.

@pieh pieh merged commit eff2cf4 into gatsbyjs:master Jan 31, 2019
mwfrost pushed a commit to mwfrost/gatsby that referenced this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants