Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-plugin-sitemap): sanitize siteUrl #12613

Merged
merged 4 commits into from
Mar 16, 2019
Merged

Conversation

rnitta
Copy link
Contributor

@rnitta rnitta commented Mar 16, 2019

Description

For sitemap plugin
Add code to remove trailing slash of siteUrl.

Related Issues

Fix #12590

Copy link
Contributor

@yogeshkotadiya yogeshkotadiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pieh pieh changed the title Gatsby-plugin-sitemap should remove the trailing slash of siteUrl feat(gatsby-plugin-sitemap): sanitize siteUrl Mar 16, 2019
@pieh pieh merged commit 41bd265 into gatsbyjs:master Mar 16, 2019
@gatsbot
Copy link

gatsbot bot commented Mar 16, 2019

Holy buckets, @rnitta — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants