fix(gatsby-source-filesystem): pin chokidar@2.1.2 to fix unix issues #12759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The e2e tests will probably still fail here--because we're not installing new versions of dependencies in the e2e tests themselves. |
|
Let's close for now--it seems like chokidar may have published a patch version. |
freiksenet
changed the title
freiksenet
approved these changes
Mar 22, 2019
|
e2e tests are expected to fail because we don't update the version of deps (currently). Let's merge and publish. |
|
|
just Released 2.1.5. |
mwfrost
pushed a commit
to mwfrost/gatsby
that referenced
this pull request
Apr 20, 2023
…atsbyjs#12759) * fix(gatsby-source-filesystem): revert to chokidar@1 to fix unix issues * chore: pin to 2.1.2 * chore: pin errywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes apparent regression introduced in #11992
Related Issues
Preliminary guess is that something changed in paulmillr/chokidar#791 (specifically, chokidar@2.1.3) which breaks some fs operations/reads on Linux. Doesn't seem to impact MacOS.