Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile node_modules like CRA does #12990

Closed
sidharthachatterjee opened this issue Apr 1, 2019 · 1 comment
Closed

Compile node_modules like CRA does #12990

sidharthachatterjee opened this issue Apr 1, 2019 · 1 comment

Comments

@sidharthachatterjee
Copy link
Contributor

We currently only run babel on user code (and not on dependencies). This causes a set of issues:

  • If dependencies use APIs that aren't available, they aren't polyfilled by babel-preset-env (Example: React uses Set and IE9 doesn't support it)
  • We don't support queries in dependencies

We should copy CRA's implementation for compiling node_modules with babel-preset-env which will fix problems like #3780
@sidharthachatterjee
Copy link
Contributor Author

Closing this because it is already open in #7064

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sidharthachatterjee @LekoArts