-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-source-filesystem): add an environment variable to control concurrent queue size #13110
feat(gatsby-source-filesystem): add an environment variable to control concurrent queue size #13110
Conversation
Thanks for changes @violy! Just curious what were values you used for timeout / retries - maybe better approach would be to change defaults there? |
as I explain on the issue #13073 — during my troubleshooting, I observed this warning, for different reasons (server overload, network / local overload) related to my stack and my work environment, and my successive attempts to valid locally my build. During my troubleshooting, I've try to change When I finally deployed my app, via netlify, there was no problem (no need to fix with custom fork 😅)! |
So if changing those didn't have any effect I'm not sure it makes sense to add yet more moving parts. I would prefer to just add |
the new possible env variables should be anywhere documented:
|
7b09d17
to
2816051
Compare
Thank you, according your comment @pieh |
Maybe it would be nice to have an "main entry point" for all "magic numbers" and a default solution how to overwrite it. |
@violy Hi 👋 Do you have time to update your PR (adding information to README) and resolve the conflicts? Would be cool to have this in! |
acb1bff
to
bbc975c
Compare
@LekoArts thanks for your request, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Any news / reviewer ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable.
Longer term, we very much prefer to bake in optimized, smart defaults (or a system that adapts, e.g. will back off the queue if failures arise) but until #10049 lands this is an OK approach that we can offer to people who are blocked in some way.
Thank you!
This download manager should also include an cache and some strategies how not redownload media assets when nothing is changed. |
Is there also a stragegy only to download the used media assets (when maybe more assets are saved in wordpress but only some used in the used articles)? |
Thanks for your hint. I was thinking i am already in the other issue. #commentOnMobileProblems ;) |
Yeah, env variables seem appropriate now as a temporary fix until we can work on #10049 |
…l concurrent queue size (gatsbyjs#13110)
related to #13073