Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-sharp): ignore sizeByPixelDensity option and add deprecation warning #13852

Merged
merged 4 commits into from
May 9, 2019
Merged

fix(gatsby-plugin-sharp): ignore sizeByPixelDensity option and add deprecation warning #13852

merged 4 commits into from
May 9, 2019

Conversation

jlengstorf
Copy link
Contributor

fixes #12743

@jlengstorf jlengstorf mentioned this pull request May 4, 2019
Closed
KyleAMathews
KyleAMathews approved these changes May 4, 2019
View reviewed changes
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on this!

Could you note in gatsby-plugin-sharp as well that this option is deprecated.

@jlengstorf
Copy link
Contributor Author

@KyleAMathews ah, good call. Just added a note to the README!

@jlengstorf
Copy link
Contributor Author

Are these test failures due to obsolete snapshots? I didn't see an actual failure, but I also can't seem to run yarn bootstrap on my machine right now (libvips errors! yay!) to try this locally.

@KyleAMathews
Copy link
Contributor

Yeah, pretty sure "obsolete" means Jest knows the tests aren't run anymore. Since you can't run them locally, you could just try editing the snapshot directly.

@jlengstorf jlengstorf merged commit 4131a09 into gatsbyjs:master May 9, 2019
@jlengstorf jlengstorf deleted the fix/deprecate-pixel-density branch May 9, 2019 21:14
@pieh pieh mentioned this pull request Apr 22, 2020
Merged
This was referenced Sep 15, 2021
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleAMathews KyleAMathews KyleAMathews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[gatsby-plugin-sharp] Density should be ignored for non-SVG images
2 participants
@jlengstorf @KyleAMathews