Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change prop name "pathContext" to "pageContext" #1456

Closed
KyleAMathews opened this issue Jul 10, 2017 · 4 comments
Closed

Change prop name "pathContext" to "pageContext" #1456

KyleAMathews opened this issue Jul 10, 2017 · 4 comments
Assignees

Comments

@KyleAMathews
Copy link
Contributor

This when creating pages you can add a context key. All data passed there is passed into pages as pathContext. I think pageContext is a more intuitive name as its context for the "page" which is the main object not "path", an attribute of the page.

Since we're at 1.0, we can just pass in both and then remove pathContext at the next major release.

Any thoughts?

@Vagr9K
Copy link
Contributor

Vagr9K commented Jul 10, 2017

pageContext is less confusing IMO.

Maybe gatsby can throw warnings when building with deprecated pathContext?
Then, it wouldn't be a surprise in 2.0.

@KyleAMathews KyleAMathews mentioned this issue Aug 19, 2017
14 tasks
@jquense jquense mentioned this issue Dec 18, 2017
13 tasks
@stale
Copy link

stale bot commented Jan 6, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Jan 6, 2018
@KyleAMathews KyleAMathews removed the stale? Issue that may be closed soon due to the original author not responding any more. label Jan 6, 2018
@monsieurnebo
Copy link
Contributor

monsieurnebo commented Jan 9, 2018

Totally agree, pathContext is confusing. pageContext will definitly fit better!

@calcsam
Copy link
Contributor

calcsam commented Jan 26, 2018

Merged into v2 branch. Going to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants